Skip to content

Support fit_partial() for LightFM - #223

Merged
blondered merged 6 commits into
MTSWebServices:mainfrom
chezou:lightfm-fit-partial
Dec 10, 2024
Merged

blondered merged 6 commits into
MTSWebServices:mainfrom
chezou:lightfm-fit-partial

Conversation

@chezou

@chezou chezou commented Dec 7, 2024 •

Copy link
Copy Markdown
Contributor

Description

Support fit_partial() for LightFM
Closes #176

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

@codecov

codecov Bot commented Dec 7, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (381bacc).
Report is 99 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #223     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        59     +14     
  Lines         2242      3876   +1634     
===========================================
+ Hits          2242      3876   +1634     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blondered blondered left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see our progress! Thanks for the PR.

Comment thread tests/models/test_lightfm.py Resolved
Comment thread tests/models/test_lightfm.py Resolved
Comment thread tests/models/test_lightfm.py Resolved
Comment thread rectools/models/lightfm.py Resolved
@chezou

chezou commented Dec 9, 2024

Copy link
Copy Markdown
Contributor Author

@blondered Applied the feedback. PTAL

Comment thread CHANGELOG.md Resolved

@blondered blondered left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@blondered
blondered merged commit 75a30c1 into MTSWebServices:main Dec 10, 2024
@chezou
chezou deleted the lightfm-fit-partial branch December 10, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fit_partial function for ImplicitALSWrapperModel and LightFMWrapperModel

2 participants